Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change lite-server baseDir path to output folder #32164

Closed
wants to merge 1 commit into from

Conversation

ngdevelop-tech
Copy link
Contributor

lite-server baseDir path should be the output folder path, So need to change baseDir="dist" to `baseDir="dist/project-name"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Current shell command to deploy application on lite-server is lite-server ---baseDir="dist", this command is not able to find the project output folder files.
Issue Number: N/A

What is the new behavior?

project work properly in lite-server

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ngdevelop-tech ngdevelop-tech requested a review from a team as a code owner August 16, 2019 10:41
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ngdevelop-tech
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kapunahelewong kapunahelewong added comp: docs-infra effort1: hours target: patch This PR is targeted for the next patch release state: needs eng review Needs technical review and approval from engineering team type: bug/fix labels Aug 16, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 16, 2019
@kapunahelewong kapunahelewong added this to Need Assistance from Eng. in docs Aug 16, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 16, 2019
@kapunahelewong kapunahelewong removed the state: needs eng review Needs technical review and approval from engineering team label Aug 20, 2019
@kapunahelewong
Copy link
Contributor

Hi @ngdevelop-tech, thank you for this fix. Could you update your commit message? That's the reason that one test is failing. Try something like:

docs: change lite-server baseDir path to output folder

That should help. Feel free to tag me when you're ready.

@kapunahelewong kapunahelewong moved this from Need Assistance from Eng. to In Review in docs Aug 20, 2019
@ngdevelop-tech
Copy link
Contributor Author

Hi @kapunahelewong, Thank you for the review, I have changed the commit message.
Please let me know if there are any changes required.

@kapunahelewong
Copy link
Contributor

kapunahelewong commented Aug 21, 2019

Thanks, for making that update, @ngdevelop-tech! It looks like those failures are flakes but rebasing might fix them. Once you've rebased, please let me know. 🌸

(edited for clarity)

@ngdevelop-tech
Copy link
Contributor Author

Hi @kapunahelewong, I have rebased the branch, but circleci checks doesn't get triggered and it is still showing errors and failing. Please let me know what changes I need to do further to fix this.
Please help.

@kapunahelewong
Copy link
Contributor

Ah, thanks, @ngdevelop-tech. It's currently at 82 commits behind (surely this happened since you tagged me). Please pardon my delay in responding. Could you rebase again? 🙏🏼(We'd have to rebase to merge anyway).

If you amend that commit message by getting rid of the following highlighted parts and push up, it should retrigger the tests:

image

When you're ready please tag me - I'll be on the lookout for the notification. Thank you!

@kapunahelewong kapunahelewong removed request for a team and IgorMinar August 27, 2019 18:32
@kapunahelewong kapunahelewong changed the title docs(deployment) : need to change lite-server baseDir path to output folder docs: change lite-server baseDir path to output folder Aug 27, 2019
@kapunahelewong
Copy link
Contributor

@ngdevelop-tech, you did it!! Well done!!! 🎉

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

Thank you for this, @ngdevelop-tech 🌟

@ngdevelop-tech
Copy link
Contributor Author

Hi @kapunahelewong, I have followed the workflow you mentioned, now all checked are passed.
Thank you for your guidance. It helped me a lot to learn new things,

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2019
@kapunahelewong
Copy link
Contributor

Caretaker, this is a docs only change. Please let me know if I can help in any way. Thanks!

@ngdevelop-tech
Copy link
Contributor Author

Thank you @kapunahelewong ,
It was a great learning experience 🙂.

atscott pushed a commit that referenced this pull request Aug 27, 2019
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"`

PR Close #32164
@atscott atscott closed this in 7c7fcd7 Aug 27, 2019
@jbogarthyde jbogarthyde moved this from In Review to Done in docs Aug 28, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"`

PR Close angular#32164
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"`

PR Close angular#32164
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants