-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change lite-server baseDir path to output folder #32164
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hi @ngdevelop-tech, thank you for this fix. Could you update your commit message? That's the reason that one test is failing. Try something like:
That should help. Feel free to tag me when you're ready. |
963f133
to
2a42cde
Compare
Hi @kapunahelewong, Thank you for the review, I have changed the commit message. |
Thanks, for making that update, @ngdevelop-tech! It looks like those failures are flakes but rebasing might fix them. Once you've rebased, please let me know. 🌸 (edited for clarity) |
Hi @kapunahelewong, I have rebased the branch, but circleci checks doesn't get triggered and it is still showing errors and failing. Please let me know what changes I need to do further to fix this. |
Ah, thanks, @ngdevelop-tech. It's currently at 82 commits behind (surely this happened since you tagged me). Please pardon my delay in responding. Could you rebase again? 🙏🏼(We'd have to rebase to merge anyway). If you amend that commit message by getting rid of the following highlighted parts and push up, it should retrigger the tests: When you're ready please tag me - I'll be on the lookout for the notification. Thank you! |
@ngdevelop-tech, you did it!! Well done!!! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😊
Thank you for this, @ngdevelop-tech 🌟
Hi @kapunahelewong, I have followed the workflow you mentioned, now all checked are passed. |
Caretaker, this is a docs only change. Please let me know if I can help in any way. Thanks! |
Thank you @kapunahelewong , |
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"` PR Close #32164
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"` PR Close angular#32164
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"` PR Close angular#32164
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
lite-server baseDir path should be the output folder path, So need to change
baseDir="dist"
to `baseDir="dist/project-name"PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current shell command to deploy application on lite-server is
lite-server ---baseDir="dist"
, this command is not able to find the project output folder files.Issue Number: N/A
What is the new behavior?
project work properly in lite-server
Does this PR introduce a breaking change?
Other information